CTPath

Severity

Blocker 15
Critical 50
Major 7,718
Minor 7,894
Info 398

Rule

Control structures should use curly braces 1,316
Class variable fields should not have public accessibility 952
Local variable and method parameter names should comply with a naming convention 510
Branches should have sufficient coverage by unit tests 396
Useless parentheses around expressions should be removed to prevent any misunderstanding 395
Sections of code should not be "commented out" 385
Field names should comply with a naming convention 385
Statements should be on separate lines 358
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 289
Methods should not be too complex 257
Package names should comply with a naming convention 175
Exception handlers should preserve the original exceptions 160
Generic exceptions should never be thrown 147
A close curly brace should be located at the beginning of a line 138
Nested code blocks should not be used 118
Strings literals should be placed on the left side when checking for equality 111
"FIXME" tags should be handled 95
Method parameters, caught exceptions and foreach variables should not be reassigned 95
"switch case" clauses should not have too many lines 92
Unused local variables should be removed 90
Local variables should not shadow class fields 88
Collapsible "if" statements should be merged 80
Collection.isEmpty() should be used to test for emptiness 78
Standard outputs should not be used directly to log anything 78
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 76
Method names should comply with a naming convention 72
Source files should not have any duplicated blocks 72
Loops should not contain more than a single "break" or "continue" statement 68
Methods should not be empty 54
Unused "private" fields should be removed 53
Loggers should be "private static final" and should share a naming convention 50
Empty arrays and collections should be returned instead of null 49
Unused method parameters should be removed 40
"switch" statements should end with "default" clauses 39
Utility classes should not have public constructors 33
Expressions should not be too complex 24
Nested blocks of code should not be left empty 23
Labels should not be used 21
Classes that override "clone" should be "Cloneable" and call "super.clone()" 20
"public static" fields should be constant 20
Exception classes should be immutable 19
Empty statements should be removed 18
Methods should not have too many parameters 16
Public methods should throw at most one checked exception 16
Classes should not be too complex 16
Octal values should not be used 16
Constant names should comply with a naming convention 14
Type parameter names should comply with a naming convention 13
Deprecated elements should have both the annotation and the Javadoc tag 12
Generic wildcard types should not be used in return parameters 12
Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used 11
Public constants and fields initialized at declaration should be "static final" rather than merely "final" 10
Lambdas and anonymous classes should not have too many lines 9
An open curly brace should be located at the end of a line 8
Try-catch blocks should not be nested 7
A field should not duplicate the name of its containing class 6
"for" loop stop conditions should be invariant 4
Case insensitive string comparisons should be made without intermediate upper or lower casing 2
Return of boolean expressions should not be wrapped into an "if-then-else" statement 2
IP addresses should not be hardcoded 1
Classes from "sun.*" packages should not be used 1
"Object.finalize()" should remain protected (versus public) when overriding 1
Class names should comply with a naming convention 1
Long suffix "L" should be upper case 1
Zoom   src/main/java/com/google/transit/realtime 1,194
Zoom   src/main/java/org/opentripplanner/visibility 504
Zoom   src/main/java/org/opentripplanner/profile 416
Zoom   src/main/java/org/opentripplanner/routing/core 399
Zoom   src/main/java/org/opentripplanner/graph_builder/module/osm 328
Zoom   src/main/java/org/opentripplanner/routing/edgetype 269
Zoom   src/main/java/org/opentripplanner/api/resource 266
Zoom   src/main/java/com/conveyal/gtfs/model 239
Zoom   src/main/java/org/opentripplanner/common/geometry 219
Zoom   src/main/java/org/opentripplanner/visualizer 155
Zoom   src/main/java/org/opentripplanner/routing/graph 153
Zoom   src/main/java/org/opentripplanner/routing/impl 152
Zoom   src/main/java/org/opentripplanner/analyst 141
Zoom   src/main/java/org/opentripplanner/graph_builder/module 123
Zoom   src/main/java/org/opentripplanner/graph_builder/module/ned 123
Zoom   src/main/java/org/opentripplanner/common 114
Zoom   src/main/java/org/opentripplanner/util 112
Zoom   src/main/java/org/opentripplanner/analyst/batch 109
Zoom   src/main/java/org/opentripplanner/osm 106
Zoom   src/main/java/org/opentripplanner/routing/edgetype/factory 92
Zoom   src/main/java/org/opentripplanner/api/model 86
Zoom   src/main/java/org/opentripplanner/analyst/request 83
Zoom   src/main/java/org/opentripplanner/standalone 78
Zoom   src/main/java/org/opentripplanner/openstreetmap/impl 70
Zoom   src/test/java/org/opentripplanner/routing/algorithm 70
Zoom   src/main/java/org/opentripplanner/graph_builder 66
Zoom   src/main/java/org/opentripplanner/openstreetmap/model 63
Zoom   src/main/java/org/opentripplanner/analyst/core 63
Zoom   src/main/java/org/opentripplanner/routing/algorithm 62
Zoom   src/main/java/org/opentripplanner/graph_builder/module/shapefile 62
Zoom   src/main/java/org/opentripplanner/updater/bike_rental 62
Zoom   src/main/java/org/opentripplanner/routing/spt 58
Zoom   src/main/java/org/opentripplanner/routing/trippattern 57
Zoom   src/main/java/org/opentripplanner/index/model 55
Zoom   src/test/java/org/opentripplanner/api/resource 55
Zoom   src/test/java/org/opentripplanner/routing/edgetype/loader 52
Zoom   src/main/java/org/opentripplanner/routing/algorithm/strategies 50
Zoom   src/test/java/org/opentripplanner/routing/core 49
Zoom   src/main/java/org/opentripplanner/graph_builder/module/map 47
Zoom   src/main/java/org/opentripplanner/graph_builder/annotation 46
Zoom   src/test/java/org/opentripplanner/routing/impl 44
Zoom   src/main/java/org/opentripplanner/routing/automata 43
Zoom   src/test/java/org/opentripplanner/graph_builder/module/osm 42
Zoom   src/main/java/org/opentripplanner/routing/util 39
Zoom   src/main/java/org/opentripplanner/api/common 38
Zoom   src/main/java/org/opentripplanner/inspector 36
Zoom   src/main/java/org/opentripplanner/api/adapters 36
Zoom   src/main/java/org/opentripplanner/updater 35
Zoom   src/main/java/org/opentripplanner/routing/edgetype/loader 34
Zoom   src/main/java/org/opentripplanner/updater/stoptime 32
Zoom   src/main/java/org/opentripplanner/scripting/api 32
Zoom   src/main/java/org/opentripplanner/api/parameter 30
Zoom   src/main/java/com/conveyal/gtfs 29
Zoom   src/main/java/org/opentripplanner/common/model 28
Zoom   src/test/java/org/opentripplanner/common/geometry 27
Zoom   src/main/java/org/opentripplanner/routing/alertpatch 27
Zoom   src/main/java/org/opensphere/geometry/algorithm 25
Zoom   src/main/java/org/opentripplanner/common/pqueue 25
Zoom   src/test/java/org/opentripplanner/routing/vertextype 24
Zoom   src/main/java/org/opentripplanner/reflect 24
Zoom   src/test/java/org/opentripplanner/graph_builder/module/shapefile 24
Zoom   src/main/java/org/opentripplanner/index 23
Zoom   src/main/java/org/opentripplanner/api/param 23
Zoom   src/test/java/org/opentripplanner/routing/edgetype 22
Zoom   src/main/java/org/opentripplanner/routing/transit_index 20
Zoom   src/main/java/org/opentripplanner/routing/pathparser 19
Zoom   src/main/java/es/uma/lcc/maxct/ctpath 18
Zoom   src/main/java/org/opentripplanner/geocoder 17
Zoom   src/main/java/org/opentripplanner/model/json_serialization 16
Zoom   src/test/java/org/opentripplanner/routing/alertpatch 15
Zoom   src/main/java/es/uma/lcc/maxct/ctpath/entities 15
Zoom   src/main/java/org/opentripplanner/model 14
Zoom   src/main/java/org/opentripplanner/graph_builder/model 14
Zoom   src/main/java/org/opentripplanner/updater/bike_park 14
Zoom   src/main/java/org/opentripplanner/api/model/error 13
Zoom   src/main/java/com/jhlabs/awt 13
Zoom   src/test/java/org/opentripplanner/routing 13
Zoom   src/main/java/es/uma/lcc/maxct/ctpath/usermanagement 13
Zoom   src/main/java/org/opentripplanner/gtfs 13
Zoom   src/main/java/org/opentripplanner/routing/services/notes 13
Zoom   src/test/java/org/opentripplanner 13
Zoom   src/main/java/org/opentripplanner/updater/street_notes 12
Zoom   src/main/java/org/opentripplanner/geocoder/google 12
Zoom   src/main/java/org/opentripplanner/updater/alerts 11
Zoom   src/main/java/org/opentripplanner/graph_builder/module/bike 11
Zoom   src/main/java/org/opentripplanner/util/xml 11
Zoom   src/main/java/org/opentripplanner/routing/bike_rental 11
Zoom   src/test/java/org/opentripplanner/common/pqueue 10
Zoom   src/main/java/org/opentripplanner/geocoder/nominatim 10
Zoom   src/main/java/org/opentripplanner/api 10
Zoom   src/main/java/org/opentripplanner/graph_builder/services 9
Zoom   src/main/java/org/opentripplanner/graph_builder/module/stopsAlerts 9
Zoom   src/main/java/org/opentripplanner/analyst/batch/aggregator 9
Zoom   src/main/java/org/opentripplanner/geocoder/reverse 8
Zoom   src/main/java/org/opentripplanner/customize 8
Zoom   src/main/java/org/opentripplanner/util/monitoring 8
Zoom   src/main/java/org/opentripplanner/geocoder/yahoo 7
Zoom   src/main/java/org/opentripplanner/util/stats 7
Zoom   src/main/java/com/conveyal/gtfs/error 7
Zoom   src/test/java/org/opentripplanner/graph_builder/module/map 6
Zoom   src/test/java/org/opentripplanner/routing/graph 6
Zoom   src/main/java/org/opentripplanner/routing/vertextype 6
Zoom   src/main/java/org/opentripplanner/graph_builder/module/extra_elevation_data 5
Zoom   src/main/java/org/opentripplanner/scripting/impl 5
Zoom   src/main/java/org/opentripplanner/updater/example 5
Zoom   src/test/java/org/opentripplanner/routing/automata 5
Zoom   src/main/java/org/opentripplanner/util/model 5
Zoom   src/test/java/org/opentripplanner/geocoder/bano 5
Zoom   src/main/java/org/opentripplanner/analyst/pointset 4
Zoom   src/main/java/org/opentripplanner/routing/services 4
Zoom   src/main/java/org/opentripplanner/graph_builder/services/ned 3
Zoom   src/main/java/org/opentripplanner/routing/request 3
Zoom   src/main/java/org/opentripplanner/extra_graph 3
Zoom   src/test/java/org/opentripplanner/graph_builder/module 3
Zoom   src/main/java/org/opentripplanner/internals 3
Zoom   src/test/java/org/opentripplanner/routing/edgetype/factory 2
Zoom   src/test/java/org/opentripplanner/updater/bike_rental 2
Zoom   src/test/java/org/opentripplanner/osm 2
Zoom   src/test/java/org/opentripplanner/openstreetmap/model 2
Zoom   src/main/java/org/opentripplanner/profile/fares 2
Zoom   src/test/java/org/opentripplanner/analyst/batch 2
Zoom   src/main/java/org/opentripplanner/graph_builder/services/shapefile 2
Zoom   src/test/java/org/opentripplanner/util 2
Zoom   src/test/java/org/opentripplanner/updater/stoptime 1
Zoom   src/main/java/org/opensphere/geometry/triangulation 1
Zoom   src/main/java/org/opentripplanner/api/model/alertpatch 1
Zoom   src/main/java/org/opentripplanner/calendar/impl 1
Zoom   src/test/java/org/opentripplanner/updater/bike_park 1
Zoom   src/test/java/org/opentripplanner/common 1
Zoom   src/test/java/org/opentripplanner/visibility 1
Zoom   src/test/java/org/opentripplanner/geocoder/yahoo 1
Zoom   src/test/java/org/opentripplanner/util/xml 1
Zoom   src/test/java/org/opentripplanner/geocoder/google 1
Zoom   src/main/java/es/uma/lcc/maxct/ctpath/dao 1
Zoom   src/test/java/org/opentripplanner/mmri 1
Zoom   src/main/java/org/opentripplanner/routing/bike_park 1
Zoom   src/main/java/org/opentripplanner/routing/error 1
Zoom   src/main/java/org/opentripplanner/api/model/transit 1
Zoom   src/main/java/org/opentripplanner/graph_builder/services/osm 1
Zoom   src/main/java/es/uma/lcc/maxct/ctpath/appsmanagement 1
Zoom   src/main/java/org/opentripplanner/geocoder/bano 1