src/main/java/org/opentripplanner/graph_builder/module/map

Severity

Blocker 0
Critical 0
Major 47
Minor 20
Info 0

Rule

Control structures should use curly braces 13
Package names should comply with a naming convention 6
Method parameters, caught exceptions and foreach variables should not be reassigned 4
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 4
Class variable fields should not have public accessibility 4
Empty arrays and collections should be returned instead of null 3
Exception handlers should preserve the original exceptions 2
Loggers should be "private static final" and should share a naming convention 2
Methods should not be too complex 2
Loops should not contain more than a single "break" or "continue" statement 2
Branches should have sufficient coverage by unit tests 2
"FIXME" tags should be handled 1
Local variable and method parameter names should comply with a naming convention 1
Sections of code should not be "commented out" 1
Magic numbers should not be used 9
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 8
Comments should not be located at the end of lines of code 2
The members of an interface declaration or class should appear in a pre-defined order 1