CTPath

Severity

Blocker 15
Critical 50
Major 7,718
Minor 7,894
Info 398

Rule

"equals(Object obj)" and "hashCode()" should be overridden in pairs 10
Throwable and Error should not be caught 3
Jump statements should not occur in "finally" blocks 1
super.finalize() should be called at the end of Object.finalize() implementations 1
Throwable.printStackTrace(...) should not be called 26
Exit methods should not be called 10
"equals(Object obj)" should be overridden along with the "compareTo(T obj)" method 6
Switch cases should end with an unconditional "break" statement 4
Execution of the Garbage Collector should be triggered only by the JVM 2
Methods named "equals" should override Object.equals(Object) 1
The Object.finalize() method should not be overriden 1
Control structures should use curly braces 1,316
Class variable fields should not have public accessibility 952
Local variable and method parameter names should comply with a naming convention 510
Branches should have sufficient coverage by unit tests 396
Useless parentheses around expressions should be removed to prevent any misunderstanding 395
Sections of code should not be "commented out" 385
Field names should comply with a naming convention 385
Statements should be on separate lines 358
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 289
Methods should not be too complex 257
Package names should comply with a naming convention 175
Exception handlers should preserve the original exceptions 160
Generic exceptions should never be thrown 147
A close curly brace should be located at the beginning of a line 138
Nested code blocks should not be used 118
Strings literals should be placed on the left side when checking for equality 111
"FIXME" tags should be handled 95
Method parameters, caught exceptions and foreach variables should not be reassigned 95
"switch case" clauses should not have too many lines 92
Unused local variables should be removed 90
Local variables should not shadow class fields 88
Collapsible "if" statements should be merged 80
Collection.isEmpty() should be used to test for emptiness 78
Standard outputs should not be used directly to log anything 78
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 76
Source files should not have any duplicated blocks 72
Method names should comply with a naming convention 72
Loops should not contain more than a single "break" or "continue" statement 68
Methods should not be empty 54
Unused "private" fields should be removed 53
Loggers should be "private static final" and should share a naming convention 50
Empty arrays and collections should be returned instead of null 49
Unused method parameters should be removed 40
"switch" statements should end with "default" clauses 39
Utility classes should not have public constructors 33
Expressions should not be too complex 24
Nested blocks of code should not be left empty 23
Labels should not be used 21
Classes that override "clone" should be "Cloneable" and call "super.clone()" 20
"public static" fields should be constant 20
Exception classes should be immutable 19
Empty statements should be removed 18
Classes should not be too complex 16
Public methods should throw at most one checked exception 16
Octal values should not be used 16
Methods should not have too many parameters 16
Constant names should comply with a naming convention 14
Type parameter names should comply with a naming convention 13
Deprecated elements should have both the annotation and the Javadoc tag 12
Generic wildcard types should not be used in return parameters 12
Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used 11
Public constants and fields initialized at declaration should be "static final" rather than merely "final" 10
Lambdas and anonymous classes should not have too many lines 9
An open curly brace should be located at the end of a line 8
Try-catch blocks should not be nested 7
A field should not duplicate the name of its containing class 6
"for" loop stop conditions should be invariant 4
Case insensitive string comparisons should be made without intermediate upper or lower casing 2
Return of boolean expressions should not be wrapped into an "if-then-else" statement 2
Classes from "sun.*" packages should not be used 1
Class names should comply with a naming convention 1
IP addresses should not be hardcoded 1
"Object.finalize()" should remain protected (versus public) when overriding 1
Long suffix "L" should be upper case 1
Magic numbers should not be used 5,496
Comments should not be located at the end of lines of code 672
The members of an interface declaration or class should appear in a pre-defined order 651
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 327
String literals should not be duplicated 228
Useless imports should be removed 189
Tabulation characters should not be used 169
Local Variables should not be declared and then immediately returned or thrown 70
Modifiers should be declared in the correct order 40
Array designators "[]" should be on the type, not the variable 38
Boolean literals should not be redundant 7
"switch" statements should have at least 3 "case" clauses 4
Constants should not be defined in interfaces 2
Overriding methods should do more than simply call the same method in the super class 1
"TODO" tags should be handled 386
Deprecated code should be removed eventually 12
Zoom   src/main/java/com/google/transit/realtime 1,956
Zoom   src/test/java/org/opentripplanner/api/resource 1,043
Zoom   src/main/java/org/opentripplanner/graph_builder/module/osm 815
Zoom   src/main/java/org/opentripplanner/profile 679
Zoom   src/main/java/org/opentripplanner/visibility 596
Zoom   src/main/java/org/opentripplanner/routing/core 575
Zoom   src/main/java/org/opentripplanner/api/resource 523
Zoom   src/main/java/org/opentripplanner/routing/edgetype 478
Zoom   src/test/java/org/opentripplanner/common/geometry 467
Zoom   src/main/java/org/opentripplanner/common/geometry 414
Zoom   src/test/java/org/opentripplanner/routing/algorithm 399
Zoom   src/test/java/org/opentripplanner/routing/core 362
Zoom   src/main/java/org/opentripplanner/visualizer 349
Zoom   src/main/java/com/conveyal/gtfs/model 337
Zoom   src/main/java/org/opentripplanner/routing/impl 264
Zoom   src/main/java/org/opentripplanner/analyst 244
Zoom   src/test/java/org/opentripplanner/routing/edgetype/loader 234
Zoom   src/main/java/org/opentripplanner/routing/graph 222
Zoom   src/main/java/org/opentripplanner/analyst/core 200
Zoom   src/main/java/es/uma/lcc/maxct/ctpath 191
Zoom   src/main/java/org/opentripplanner/graph_builder/module/ned 190
Zoom   src/main/java/org/opentripplanner/common 184
Zoom   src/main/java/org/opentripplanner/util 180
Zoom   src/main/java/org/opentripplanner/analyst/batch 178
Zoom   src/main/java/org/opentripplanner/graph_builder/module 168
Zoom   src/test/java/org/opentripplanner/visibility 168
Zoom   src/test/java/org/opentripplanner/routing/edgetype 164
Zoom   src/main/java/org/opentripplanner/routing/edgetype/factory 162
Zoom   src/test/java/org/opentripplanner/routing 158
Zoom   src/main/java/org/opentripplanner/osm 151
Zoom   src/test/java/org/opentripplanner/mmri 148
Zoom   src/main/java/org/opentripplanner/analyst/request 146
Zoom   src/test/java/org/opentripplanner/graph_builder/module/osm 131
Zoom   src/test/java/org/opentripplanner/routing/impl 122
Zoom   src/main/java/org/opentripplanner/standalone 122
Zoom   src/main/java/org/opentripplanner/api/model 113
Zoom   src/main/java/org/opentripplanner/openstreetmap/impl 106
Zoom   src/main/java/org/opentripplanner/api/adapters 105
Zoom   src/test/java/org/opentripplanner/graph_builder/module/map 100
Zoom   src/main/java/org/opentripplanner/routing/algorithm 92
Zoom   src/main/java/org/opentripplanner/graph_builder/module/shapefile 87
Zoom   src/main/java/org/opentripplanner/graph_builder 86
Zoom   src/main/java/org/opentripplanner/graph_builder/annotation 83
Zoom   src/main/java/org/opentripplanner/openstreetmap/model 82
Zoom   src/test/java/org/opentripplanner/routing/graph 81
Zoom   src/main/java/org/opentripplanner/updater/bike_rental 80
Zoom   src/main/java/org/opentripplanner/inspector 80
Zoom   src/main/java/org/opentripplanner/routing/spt 79
Zoom   src/main/java/org/opentripplanner/routing/trippattern 79
Zoom   src/main/java/org/opentripplanner/api/common 78
Zoom   src/main/java/org/opentripplanner/routing/util 73
Zoom   src/main/java/org/opentripplanner/gtfs 70
Zoom   src/main/java/org/opentripplanner/routing/algorithm/strategies 69
Zoom   src/main/java/org/opentripplanner/graph_builder/module/map 67
Zoom   src/main/java/org/opentripplanner/updater 62
Zoom   src/main/java/org/opentripplanner/index/model 60
Zoom   src/main/java/org/opentripplanner/api/parameter 59
Zoom   src/test/java/org/opentripplanner/routing/alertpatch 56
Zoom   src/test/java/org/opentripplanner/routing/trippattern 52
Zoom   src/main/java/org/opentripplanner/api/param 52
Zoom   src/main/java/org/opentripplanner/updater/stoptime 52
Zoom   src/main/java/org/opentripplanner/routing/automata 51
Zoom   src/main/java/org/opentripplanner/scripting/api 47
Zoom   src/test/java/org/opentripplanner/routing/vertextype 46
Zoom   src/main/java/org/opentripplanner/common/pqueue 44
Zoom   src/main/java/com/conveyal/gtfs 43
Zoom   src/test/java/org/opentripplanner/graph_builder/module/shapefile 43
Zoom   src/main/java/org/opentripplanner/routing/edgetype/loader 37
Zoom   src/main/java/es/uma/lcc/maxct/ctpath/entities 36
Zoom   src/main/java/org/opentripplanner/common/model 35
Zoom   src/main/java/org/opensphere/geometry/algorithm 34
Zoom   src/main/java/org/opentripplanner/reflect 34
Zoom   src/main/java/org/opentripplanner/index 33
Zoom   src/main/java/org/opentripplanner/routing/alertpatch 32
Zoom   src/main/java/com/jhlabs/awt 27
Zoom   src/test/java/org/opentripplanner/common/pqueue 27
Zoom   src/test/java/org/opentripplanner/common/model 25
Zoom   src/main/java/org/opentripplanner/model 23
Zoom   src/main/java/es/uma/lcc/maxct/ctpath/usermanagement 22
Zoom   src/test/java/org/opentripplanner 22
Zoom   src/main/java/org/opentripplanner/geocoder 22
Zoom   src/main/java/org/opentripplanner/routing/transit_index 22
Zoom   src/test/java/org/opentripplanner/analyst/batch 21
Zoom   src/main/java/org/opentripplanner/geocoder/google 21
Zoom   src/test/java/org/opentripplanner/updater/bike_park 21
Zoom   src/main/java/org/opentripplanner/routing/pathparser 21
Zoom   src/test/java/org/opentripplanner/util 20
Zoom   src/test/java/org/opentripplanner/profile 19
Zoom   src/test/java/org/opentripplanner/routing/util 19
Zoom   src/main/java/org/opentripplanner/model/json_serialization 18
Zoom   src/main/java/org/opentripplanner/routing/services/notes 17
Zoom   src/main/java/org/opentripplanner/updater/bike_park 17
Zoom   src/main/java/org/opentripplanner/graph_builder/model 17
Zoom   src/main/java/org/opentripplanner/updater/alerts 16
Zoom   src/main/java/org/opentripplanner/api 16
Zoom   src/main/java/org/opentripplanner/updater/street_notes 16
Zoom   src/main/java/org/opentripplanner/geocoder/yahoo 16
Zoom   src/main/java/org/opentripplanner/customize 14
Zoom   src/main/java/org/opentripplanner/routing/bike_rental 14
Zoom   src/main/java/org/opentripplanner/geocoder/reverse 13
Zoom   src/main/java/org/opentripplanner/analyst/batch/aggregator 13
Zoom   src/test/java/org/opentripplanner/openstreetmap/model 13
Zoom   src/test/java/org/opentripplanner/common 13
Zoom   src/main/java/org/opentripplanner/api/model/error 13
Zoom   src/test/java/org/opentripplanner/geocoder/bano 13
Zoom   src/main/java/org/opentripplanner/graph_builder/module/stopsAlerts 12
Zoom   src/main/java/org/opentripplanner/geocoder/nominatim 12
Zoom   src/main/java/org/opentripplanner/routing/vertextype 12
Zoom   src/main/java/org/opentripplanner/util/xml 12
Zoom   src/main/java/org/opentripplanner/graph_builder/module/bike 11
Zoom   src/main/java/org/opentripplanner/graph_builder/services 11
Zoom   src/main/java/com/conveyal/gtfs/error 10
Zoom   src/main/java/org/opentripplanner/util/monitoring 9
Zoom   src/main/java/org/opentripplanner/updater/example 8
Zoom   src/test/java/org/opentripplanner/osm 8
Zoom   src/main/java/org/opentripplanner/util/stats 8
Zoom   src/test/java/org/opentripplanner/analyst 8
Zoom   src/main/java/org/opentripplanner/util/model 8
Zoom   src/test/java/org/opentripplanner/updater/bike_rental 8
Zoom   src/main/java/org/opentripplanner/internals 8
Zoom   src/test/java/org/opentripplanner/gtfs 8
Zoom   src/test/java/org/opentripplanner/graph_builder/module 7
Zoom   src/test/java/org/opentripplanner/geocoder/yahoo 7
Zoom   src/test/java/org/opentripplanner/geocoder/google 7
Zoom   src/test/java/org/opentripplanner/updater/stoptime 6
Zoom   src/main/java/org/opentripplanner/routing/services 6
Zoom   src/test/java/org/opentripplanner/util/xml 6
Zoom   src/main/java/org/opentripplanner/graph_builder/module/extra_elevation_data 6
Zoom   src/main/java/org/opentripplanner/analyst/pointset 6
Zoom   src/main/java/org/opentripplanner/scripting/impl 5
Zoom   src/test/java/org/opentripplanner/routing/automata 5
Zoom   src/test/java/org/opentripplanner/geocoder/ws 5
Zoom   src/test/java/org/opentripplanner/routing/edgetype/factory 4
Zoom   src/main/java/org/opentripplanner/extra_graph 4
Zoom   src/main/java/org/opentripplanner/profile/fares 3
Zoom   src/main/java/org/opentripplanner/routing/request 3
Zoom   src/main/java/org/opensphere/geometry/triangulation/model 3
Zoom   src/main/java/org/opentripplanner/graph_builder/services/ned 3
Zoom   src/main/java/es/uma/lcc/maxct/ctpath/appsmanagement 3
Zoom   src/main/java/org/opentripplanner/routing/location 3
Zoom   src/main/java/org/opentripplanner/routing/error 2
Zoom   src/main/java/org/opentripplanner/graph_builder/services/shapefile 2
Zoom   src/main/java/es/uma/lcc/maxct/ctpath/dao 2
Zoom   src/main/java/org/opentripplanner/geocoder/bano 2
Zoom   src/main/java/org/opentripplanner/api/model/transit 2
Zoom   src/main/java/org/opentripplanner/calendar/impl 2
Zoom   src/main/java/org/opensphere/geometry/triangulation 2
Zoom   src/test/java/org/opentripplanner/util/model 2
Zoom   src/main/java/com/conveyal/gtfs/validator 1
Zoom   src/main/java/org/opentripplanner/routing/bike_park 1
Zoom   src/main/java/org/opentripplanner/graph_builder/services/osm 1
Zoom   src/main/java/org/opentripplanner/api/model/alertpatch 1
Zoom   src/test/java/org/opentripplanner/api/model 1
  GtfsRealtime.java 1,956
  GraphPathToTripPlanConverterTest.java 995
  DefaultWayPropertySetSource.java 362
  RoutingRequest.java 244
  ShowGraph.java 224
  TestPatternHopFactory.java 198
  TestVisibilityGraph.java 168
  GeometryUtilsTest.java 161
  ProfileRouter.java 156
  Tile.java 148
  SIsochrone.java 140
  DCFareCalculator.java 134
  GTFSPatternHopFactory.java 127
  TestDistanceLib.java 125
  OpenStreetMapModule.java 122
  GraphVisualizer.java 110
  LineSegment.java 108
  VLPolygon.java 107
  TestHalfEdges.java 104
  AStarTest.java 101
  Graph.java 100
  TestStreetMatcher.java 100
  VLPoint.java 97
  GraphPathToTripPlanConverter.java 95
  GraphIndex.java 92
  OSMDatabase.java 90
  StreetEdge.java 90
  RecursiveGridIsolineBuilder.java 86
  TurnCostTest.java 86
  PointSet.java 85
  RoutingContextTest.java 79
  Timetable.java 76
  TripPattern.java 76
  NEDDownloader.java 75
  TestTransfers.java 71
  VisibilityPolygon.java 68
  Environment.java 66
  State.java 65
  CompactLineStringTest.java 62
  TurnRestrictionTest.java 62
  Entity.java 61
  SimpleTraversalCostModelTest.java 59
  ElevationModule.java 58
  AnalystProfileRouterPrototype.java 57
  NycFareServiceImpl.java 57
  DlugoszVarLenIntPacker.java 56
  DateUtils.java 56
  AlertPatchTest.java 56
  WalkableAreaBuilder.java 55
  GtfsLibrary.java 54
  ClosestEdgesTest.java 54
  GraphTest.java 54
  Stats.java 53
  GraphPathFinderTest.java 52
  TripTimesTest.java 52
  TimeSurface.java 50
  Ride.java 50
  GraphPathFinder.java 50
  RepeatingTimePeriod.java 49
  ElevationUtils.java 49
  DirectionUtilsTest.java 48
  GraphBuilder.java 46
  InterleavedBidirectionalHeuristic.java 46
  IntersectionVertexTest.java 46
  WayPropertySet.java 45
  AStar.java 45
  RoutingContext.java 45
  RoutingResource.java 44
  BinHeap.java 44
  TestGraph.java 43
  PlainStreetEdgeTest.java 43
  OnBoardDepartServiceImplTest.java 43
  PlannerRequest.java 42
  TimetableTest.java 42
  SedanPollutionModel.java 40
  TruckPollutionModel.java 40
  VanPollutionModel.java 40
  SampleGridRenderer.java 39
  SurfaceResource.java 39
  ShapefileStreetModule.java 39
  RasterPopulation.java 38
  SparseMatrix.java 38
  SparseMatrixTest.java 38
  TransitBoardAlight.java 37
  TestParkAndRide.java 37
  GTFSFeed.java 36
  EdgeVertexTileRenderer.java 36
  StreetVertexIndexServiceImpl.java 36
  FrequencyEntry.java 36
  TestHopFactory.java 36
  Parser.java 35
  VexFormatCodec.java 35
  WagonPollutionModel.java 34
  ConcaveHull.java 34
  GtfsModule.java 34
  NearbyStopFinder.java 34
  OSMLevel.java 34
  TestOnBoardRouting.java 34
  MavenVersion.java 33
  GraphStats.java 33
  OpenStreetMapParserTest.java 33
  TestWayPropertySet.java 33
  PatternInterlineDwellTest.java 33
  PackedCoordinateSequence.java 32
  SparseMatrixZSampleGrid.java 32
  IndexAPI.java 32
  ProfileRequest.java 32
  GraphUpdaterConfigurator.java 32
  TestOpenStreetMapGraphBuilder.java 32
  Shape.java 31
  Stop.java 31
  Message.java 31
  ReflectiveInitializer.java 31
  StreetTraversalPermission.java 31
  OTPMain.java 31
  Angle.java 31
  TestBanning.java 31
  SimpleIsochrone.java 30
  TimeGridWs.java 30
  OSMWithTags.java 30
  RouteMatcher.java 29
  TripTimes.java 29
  BatchProcessor.java 28
  Leg.java 28
  Segment.java 28
  TestOverlayGraph.java 28
  StopTime.java 27
  Trip.java 27
  TestPQueues.java 27
  PatternRide.java 26
  PatternInterlineDwell.java 26
  IntUtils.java 26
  TestBikeRental.java 26
  GraphMetadata.java 25
  Routers.java 25
  LuceneIndex.java 25
  BitSetUtils.java 25
  GenericLocationTest.java 25
  TestAStar.java 25
  Route.java 24
  WalkStep.java 24
  OSMFilter.java 24
  GenericDijkstra.java 24
  GraphPath.java 24
  Polyline.java 24
  Ray.java 24
  TestShapefileStreetGraphBuilderImpl.java 24
  CSVPopulation.java 23
  OverlayGraph.java 23
  SpecificTransfer.java 23
  StateEditor.java 23
  LinkRequest.java 23
  Itinerary.java 22
  YearMonthDay.java 22
  StopPattern.java 22
  OSMDownloader.java 22
  Option.java 22
  TimeRange.java 22
  InputStreamGraphSource.java 22
  TestTriangle.java 22
  CarPollutionModel.java 21
  DFA.java 21
  DefaultFareServiceImpl.java 21
  CSVPopulationTest.java 21
  TransferTimeTest.java 21
  TestKmlBikeParkSource.java 21
  ResultSet.java 20
  ProfileResource.java 20
  AccumulativeGridSampler.java 20
  CompactLineString.java 20
  OpenStreetMapParser.java 20
  AlertPatch.java 20
  SFBayFareServiceImpl.java 20
  SPTWalker.java 20
  CommandLineParameters.java 20
  Router.java 20
  PolylineEncoder.java 20
  Calendar.java 19
  TextStroke.java 19
  Histogram.java 19
  StreetMatcher.java 19
  OSMSpecifier.java 19
  EarliestArrivalSearch.java 19
  TimeWindowTest.java 19
  TestFares.java 19
  GraphServiceTest.java 19
  Namer.java 18
  VerticalDatum.java 18
  Area.java 18
  PortlandCustomNamer.java 18
  BikeRentalUpdater.java 18
  TimetableSnapshotSource.java 18
  CompactElevationProfileTest.java 18
  TimeTest.java 18
  PartialStreetEdgeTest.java 18
  FareAttribute.java 17
  FeedInfo.java 17
  BasicPopulation.java 17
  Renderer.java 17
  SampleFactory.java 17