src/main/java/org/opentripplanner/util

Severity

Blocker 0
Critical 0
Major 112
Minor 65
Info 3

Rule

Control structures should use curly braces 35
Exception handlers should preserve the original exceptions 13
Method parameters, caught exceptions and foreach variables should not be reassigned 12
Branches should have sufficient coverage by unit tests 8
Utility classes should not have public constructors 8
Field names should comply with a naming convention 6
Nested blocks of code should not be left empty 5
Generic exceptions should never be thrown 4
Strings literals should be placed on the left side when checking for equality 3
Local variable and method parameter names should comply with a naming convention 2
Sections of code should not be "commented out" 2
Methods should not be too complex 2
Statements should be on separate lines 2
Useless parentheses around expressions should be removed to prevent any misunderstanding 1
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 1
Loggers should be "private static final" and should share a naming convention 1
Public methods should throw at most one checked exception 1
Case insensitive string comparisons should be made without intermediate upper or lower casing 1
Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used 1
Try-catch blocks should not be nested 1
"FIXME" tags should be handled 1
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 1
An open curly brace should be located at the end of a line 1
Magic numbers should not be used 38
Modifiers should be declared in the correct order 15
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 6
Constants should not be defined in interfaces 2
Local Variables should not be declared and then immediately returned or thrown 2
Array designators "[]" should be on the type, not the variable 1
Comments should not be located at the end of lines of code 1
"TODO" tags should be handled 3