src/main/java/org/opentripplanner/visualizer

Severity

Blocker 0
Critical 4
Major 155
Minor 183
Info 7

Rule

Throwable.printStackTrace(...) should not be called 3
Exit methods should not be called 1
Sections of code should not be "commented out" 24
Control structures should use curly braces 21
Standard outputs should not be used directly to log anything 17
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 15
Class variable fields should not have public accessibility 9
Octal values should not be used 8
Methods should not be too complex 7
Local variable and method parameter names should comply with a naming convention 5
Field names should comply with a naming convention 5
Public constants and fields initialized at declaration should be "static final" rather than merely "final" 5
A close curly brace should be located at the beginning of a line 4
Useless parentheses around expressions should be removed to prevent any misunderstanding 4
Collapsible "if" statements should be merged 4
Method parameters, caught exceptions and foreach variables should not be reassigned 4
Methods should not be empty 4
Branches should have sufficient coverage by unit tests 3
"FIXME" tags should be handled 3
Exception handlers should preserve the original exceptions 3
Unused "private" fields should be removed 2
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 2
Unused method parameters should be removed 1
Lambdas and anonymous classes should not have too many lines 1
Expressions should not be too complex 1
Statements should be on separate lines 1
Classes should not be too complex 1
Source files should not have any duplicated blocks 1
Magic numbers should not be used 150
Comments should not be located at the end of lines of code 23
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 4
Tabulation characters should not be used 3
Local Variables should not be declared and then immediately returned or thrown 2
Useless imports should be removed 1
"TODO" tags should be handled 7