src/main/java/org/opentripplanner/graph_builder/module

Severity

Blocker 0
Critical 2
Major 123
Minor 37
Info 6

Rule

Throwable.printStackTrace(...) should not be called 1
"equals(Object obj)" should be overridden along with the "compareTo(T obj)" method 1
Control structures should use curly braces 23
Package names should comply with a naming convention 16
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 13
Branches should have sufficient coverage by unit tests 13
Field names should comply with a naming convention 10
Statements should be on separate lines 10
Methods should not be too complex 6
Class variable fields should not have public accessibility 6
"FIXME" tags should be handled 5
Generic exceptions should never be thrown 4
Loggers should be "private static final" and should share a naming convention 3
Collapsible "if" statements should be merged 3
Sections of code should not be "commented out" 2
Unused method parameters should be removed 1
Methods should not be empty 1
Source files should not have any duplicated blocks 1
Loops should not contain more than a single "break" or "continue" statement 1
Collection.isEmpty() should be used to test for emptiness 1
Unused "private" fields should be removed 1
Empty statements should be removed 1
A close curly brace should be located at the beginning of a line 1
Local variable and method parameter names should comply with a naming convention 1
Magic numbers should not be used 13
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 9
Comments should not be located at the end of lines of code 8
The members of an interface declaration or class should appear in a pre-defined order 4
Array designators "[]" should be on the type, not the variable 2
Tabulation characters should not be used 1
"TODO" tags should be handled 6