src/main/java/org/opentripplanner/analyst

Severity

Blocker 0
Critical 0
Major 141
Minor 87
Info 16

Rule

Control structures should use curly braces 30
Class variable fields should not have public accessibility 30
Nested code blocks should not be used 15
Exception handlers should preserve the original exceptions 9
Strings literals should be placed on the left side when checking for equality 8
Branches should have sufficient coverage by unit tests 8
Local variable and method parameter names should comply with a naming convention 5
Public methods should throw at most one checked exception 5
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 4
Methods should not be too complex 4
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 3
"FIXME" tags should be handled 3
Unused local variables should be removed 2
Local variables should not shadow class fields 2
Loops should not contain more than a single "break" or "continue" statement 1
Method parameters, caught exceptions and foreach variables should not be reassigned 1
Methods should not be empty 1
Unused method parameters should be removed 1
Exception classes should be immutable 1
Unused "private" fields should be removed 1
Expressions should not be too complex 1
Generic exceptions should never be thrown 1
A close curly brace should be located at the beginning of a line 1
Long suffix "L" should be upper case 1
Empty statements should be removed 1
Sections of code should not be "commented out" 1
Source files should not have any duplicated blocks 1
Magic numbers should not be used 22
Useless imports should be removed 22
Comments should not be located at the end of lines of code 15
Tabulation characters should not be used 9
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 9
String literals should not be duplicated 6
Array designators "[]" should be on the type, not the variable 2
The members of an interface declaration or class should appear in a pre-defined order 1
Local Variables should not be declared and then immediately returned or thrown 1
"TODO" tags should be handled 16