CTPath

Severity

Blocker 15
Critical 50
Major 7,718
Minor 7,894
Info 398

Rule

"equals(Object obj)" and "hashCode()" should be overridden in pairs 10
Throwable and Error should not be caught 3
Jump statements should not occur in "finally" blocks 1
super.finalize() should be called at the end of Object.finalize() implementations 1
Throwable.printStackTrace(...) should not be called 26
Exit methods should not be called 10
"equals(Object obj)" should be overridden along with the "compareTo(T obj)" method 6
Switch cases should end with an unconditional "break" statement 4
Execution of the Garbage Collector should be triggered only by the JVM 2
Methods named "equals" should override Object.equals(Object) 1
The Object.finalize() method should not be overriden 1
Control structures should use curly braces 1,316
Class variable fields should not have public accessibility 952
Local variable and method parameter names should comply with a naming convention 510
Branches should have sufficient coverage by unit tests 396
Useless parentheses around expressions should be removed to prevent any misunderstanding 395
Sections of code should not be "commented out" 385
Field names should comply with a naming convention 385
Statements should be on separate lines 358
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 289
Methods should not be too complex 257
Package names should comply with a naming convention 175
Exception handlers should preserve the original exceptions 160
Generic exceptions should never be thrown 147
A close curly brace should be located at the beginning of a line 138
Nested code blocks should not be used 118
Strings literals should be placed on the left side when checking for equality 111
"FIXME" tags should be handled 95
Method parameters, caught exceptions and foreach variables should not be reassigned 95
"switch case" clauses should not have too many lines 92
Unused local variables should be removed 90
Local variables should not shadow class fields 88
Collapsible "if" statements should be merged 80
Collection.isEmpty() should be used to test for emptiness 78
Standard outputs should not be used directly to log anything 78
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 76
Source files should not have any duplicated blocks 72
Method names should comply with a naming convention 72
Loops should not contain more than a single "break" or "continue" statement 68
Methods should not be empty 54
Unused "private" fields should be removed 53
Loggers should be "private static final" and should share a naming convention 50
Empty arrays and collections should be returned instead of null 49
Unused method parameters should be removed 40
"switch" statements should end with "default" clauses 39
Utility classes should not have public constructors 33
Expressions should not be too complex 24
Nested blocks of code should not be left empty 23
Labels should not be used 21
Classes that override "clone" should be "Cloneable" and call "super.clone()" 20
"public static" fields should be constant 20
Exception classes should be immutable 19
Empty statements should be removed 18
Classes should not be too complex 16
Public methods should throw at most one checked exception 16
Octal values should not be used 16
Methods should not have too many parameters 16
Constant names should comply with a naming convention 14
Type parameter names should comply with a naming convention 13
Deprecated elements should have both the annotation and the Javadoc tag 12
Generic wildcard types should not be used in return parameters 12
Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used 11
Public constants and fields initialized at declaration should be "static final" rather than merely "final" 10
Lambdas and anonymous classes should not have too many lines 9
An open curly brace should be located at the end of a line 8
Try-catch blocks should not be nested 7
A field should not duplicate the name of its containing class 6
"for" loop stop conditions should be invariant 4
Case insensitive string comparisons should be made without intermediate upper or lower casing 2
Return of boolean expressions should not be wrapped into an "if-then-else" statement 2
Classes from "sun.*" packages should not be used 1
Class names should comply with a naming convention 1
IP addresses should not be hardcoded 1
"Object.finalize()" should remain protected (versus public) when overriding 1
Long suffix "L" should be upper case 1
Magic numbers should not be used 5,496
Comments should not be located at the end of lines of code 672
The members of an interface declaration or class should appear in a pre-defined order 651
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 327
String literals should not be duplicated 228
Useless imports should be removed 189
Tabulation characters should not be used 169
Local Variables should not be declared and then immediately returned or thrown 70
Modifiers should be declared in the correct order 40
Array designators "[]" should be on the type, not the variable 38
Boolean literals should not be redundant 7
"switch" statements should have at least 3 "case" clauses 4
Constants should not be defined in interfaces 2
Overriding methods should do more than simply call the same method in the super class 1
"TODO" tags should be handled 386
Deprecated code should be removed eventually 12
Zoom   src/main/java/org/opentripplanner/graph_builder/annotation 39
Zoom   src/main/java/org/opentripplanner/graph_builder/module/osm 25
Zoom   src/main/java/org/opentripplanner/graph_builder/module 16
Zoom   src/main/java/org/opentripplanner/graph_builder/module/shapefile 14
Zoom   src/main/java/org/opentripplanner/updater/bike_rental 12
Zoom   src/main/java/org/opentripplanner/model/json_serialization 10
Zoom   src/main/java/org/opentripplanner/graph_builder/module/ned 7
Zoom   src/test/java/org/opentripplanner/graph_builder/module/osm 7
Zoom   src/main/java/org/opentripplanner/graph_builder/module/map 6
Zoom   src/main/java/org/opentripplanner/graph_builder/module/stopsAlerts 4
Zoom   src/test/java/org/opentripplanner/graph_builder/module/shapefile 4
Zoom   src/main/java/org/opentripplanner/graph_builder/services 4
Zoom   src/main/java/org/opentripplanner/graph_builder 3
Zoom   src/main/java/org/opentripplanner/updater/bike_park 3
Zoom   src/main/java/org/opentripplanner/graph_builder/module/bike 2
Zoom   src/main/java/org/opentripplanner/routing/bike_rental 2
Zoom   src/main/java/org/opentripplanner/graph_builder/services/shapefile 2
Zoom   src/main/java/org/opentripplanner/updater/street_notes 2
Zoom   src/main/java/org/opentripplanner/graph_builder/services/ned 2
Zoom   src/main/java/org/opentripplanner/routing/transit_index 2
Zoom   src/main/java/org/opentripplanner/graph_builder/module/extra_elevation_data 2
Zoom   src/test/java/org/opentripplanner/graph_builder/module/map 1
Zoom   src/test/java/org/opentripplanner/graph_builder/module 1
Zoom   src/test/java/org/opentripplanner/updater/bike_rental 1
Zoom   src/main/java/org/opentripplanner/graph_builder/model 1
Zoom   src/test/java/org/opentripplanner/updater/bike_park 1
Zoom   src/main/java/org/opentripplanner/graph_builder/services/osm 1
Zoom   src/main/java/org/opentripplanner/extra_graph 1
  EdgeSetJSONSerializer.java 1
  Area.java 1
  NegativeDwellTime.java 1
  TestStreetMatcher.java 1
  CompositeStreetTraversalPermissionConverter.java 1
  GtfsModule.java 1
  VertexSetJSONSerializer.java 1
  NotePicker.java 1
  StopAtEntrance.java 1
  TestWayPropertySet.java 1
  ShapefileStreetModule.java 1
  TransitToTaggedStopsModule.java 1
  BikeParkUnlinked.java 1
  BikeParkDataSource.java 1
  OpenStreetMapModule.java 1
  TripDuplicateDeparture.java 1
  TestKmlBikeParkSource.java 1
  UnconnectedStop.java 1
  EndMatchState.java 1
  BogusVertexGeometry.java 1
  BixiBikeRentalDataSource.java 1
  TemplateLibrary.java 1
  VertexShapeError.java 1
  NEDTileSource.java 1
  ElevationModule.java 1
  HopSpeedFast.java 1
  KeolisRennesBikeRentalDataSource.java 1
  WayPropertySetSource.java 1
  EmbedConfig.java 1
  ShapefileFeatureSourceFactoryImpl.java 1
  TransitToStreetNetworkModule.java 1
  AgencyNameCollision.java 1
  RouteVariant.java 1
  OSMSpecifier.java 1
  TripDuplicate.java 1
  TestShapefileStreetGraphBuilderImpl.java 1
  TransitType.java 1
  BusRouteStreetMatcher.java 1
  BogusShapeGeometryCaught.java 1
  BikeRentalUpdater.java 1
  SpeedPicker.java 1
  TurnRestrictionUnknown.java 1
  ElevationGridCoverageFactory.java 1
  DegreeGridNEDTileSource.java 1
  Graphwide.java 1
  JCDecauxBikeRentalDataSource.java 1
  WayPropertySet.java 1
  DownloadableGtfsInputSource.java 1
  CoordinateSerializer.java 1
  VerticalDatum.java 1
  LevelAmbiguous.java 1
  GtfsGraphBuilderModuleTest.java 1
  CompositeBooleanConverter.java 1
  GraphStatisticsModule.java 1
  SerializerUtils.java 1
  DefaultWayPropertySetSource.java 1
  RepeatedStops.java 1
  TestUnroutable.java 1
  SlopeOverridePicker.java 1
  TurnRestrictionException.java 1
  StreetEdgeFactory.java 1
  StreetMatcher.java 1
  GraphConnectivity.java 1
  GenericXmlBikeRentalDataSource.java 1
  WayPropertyPicker.java 1
  DirectTransferGenerator.java 1
  BogusGeometryFactory.java 1
  UnifiedGridCoverage.java 1
  InterliningTeleport.java 1
  WinkkiPollingGraphUpdater.java 1
  CaseBasedTraversalPermissionConverter.java 1
  GraphCoherencyCheckerModule.java 1
  PackedCoordinateSequenceSerializer.java 1
  CreativeNamerPicker.java 1
  ParkAndRideUnlinked.java 1
  TestUnconnectedAreas.java 1
  NullBooleanConverter.java 1
  TransitStopsRegionsSourceImpl.java 1
  GraphStats.java 1
  RouteSegment.java 1
  OSMFilter.java 1
  TripDegenerate.java 1
  TestCaseBasedTraversalPermissionConverter.java 1
  IStopTester.java 1
  ExtraElevationData.java 1
  BogusShapeGeometry.java 1
  BikeRentalDataSource.java 1
  HopZeroTime.java 1
  WFSNotePollingGraphUpdater.java 1
  CaseBasedBooleanConverter.java 1
  FareServiceModule.java 1
  GeoJSONSerializer.java 1
  CreativeNamerEditor.java 1
  NonStationParentStation.java 1
  TestTemplateLibrary.java 1
  JoinedFeatureConverter.java 1
  StopsAlerts.java 1
  GraphBuilder.java 1
  TimeBasedBikeRentalFareService.java 1
  OSMDatabase.java 1
  StreetCarSpeedZero.java 1
  StubSimpleFeature.java 1
  AbstractStopTester.java 1
  ElevationPoint.java 1
  BogusShapeDistanceTraveled.java 1
  BCycleBikeRentalDataSource.java 1
  SafetyFeaturesEditor.java 1
  TurnRestrictionBad.java 1
  GraphBuilderModule.java 1
  MidblockMatchState.java 1
  GraphBuilderAnnotation.java 1
  GenericKmlBikeRentalDataSource.java 1
  WayProperties.java 1
  CheckGeometryModule.java 1
  SimpleFeatureConverter.java 1
  NEDGridCoverageFactoryImpl.java 1
  AnnotationsToHTML.java 1
  BikeRentalStationService.java 1
  NotePropertiesEditor.java 1
  StopUnlinked.java 1
  CompositeConverterTest.java 1
  StringAttributeFeatureConverter.java 1
  BikeRentalModule.java 1
  BogusEdgeGeometry.java 1
  KmlBikeParkDataSource.java 1
  Ring.java 1
  TripUndefinedService.java 1
  EntityReplacementStrategy.java 1
  MatchState.java 1
  ElevationFlattened.java 1
  GenericJsonBikeRentalDataSource.java 1
  WalkableAreaBuilder.java 1
  GtfsBundle.java 1
  FeatureSourceFactory.java 1
  NEDDownloader.java 1
  HopZeroDistance.java 1
  VCubDataSource.java 1
  CaseBasedBicycleSafetyFeatureConverter.java 1
  EntityReplacementStrategyImpl.java 1
  GeoJSONDeserializer.java 1
  CreativeNamer.java 1
  NoFutureDates.java 1
  TestOpenStreetMapGraphBuilder.java 1
  FeatureIdConverter.java 1
  PruneFloatingIslands.java 1
  LinearIterator.java 1
  ConflictingBikeTags.java 1
  CityBikesBikeRentalDataSource.java 1
  TurnRestrictionTag.java 1
  package-info.java 1
  CustomNamer.java 1
  GeotiffGridCoverageFactoryImpl.java 1
  HopSpeedSlow.java 1
  OVFietsKMLDataSource.java 1
  AttributeFeatureConverter.java 1
  EntityReplacementStrategyFactory.java 1
  EncodedPolylineJSONSerializer.java 1
  AreaGroup.java 1
  NegativeHopTime.java 1
  OpenStreetMapParserTest.java 1
  DirectSafetyReader.java 1
  NearbyStopFinder.java 1
  EdgesForRoute.java 1
  WithGraph.java 1
  NoteProperties.java 1
  StopNotLinkedForTransfers.java 1
  TriangleInequalityTest.java 1
  ShapefileStreetSchema.java 1
  BikeParkModule.java 1
  BikeRentalStationUnlinked.java 1
  BikeParkUpdater.java 1
  PortlandCustomNamer.java 1
  TripOvertaking.java 1
  TestBikeRentalStationSource.java 1
  DefaultStreetEdgeFactory.java 1