src/main/java/org/opentripplanner/visibility

Severity

Blocker 3
Critical 0
Major 504
Minor 89
Info 0

Rule

Local variable and method parameter names should comply with a naming convention 180
Control structures should use curly braces 124
Method names should comply with a naming convention 53
Useless parentheses around expressions should be removed to prevent any misunderstanding 26
Collection.isEmpty() should be used to test for emptiness 19
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 17
Field names should comply with a naming convention 15
Sections of code should not be "commented out" 13
Branches should have sufficient coverage by unit tests 9
Methods should not be too complex 8
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 8
Class variable fields should not have public accessibility 5
An open curly brace should be located at the end of a line 5
"switch case" clauses should not have too many lines 4
Classes that override "clone" should be "Cloneable" and call "super.clone()" 4
"switch" statements should end with "default" clauses 3
Expressions should not be too complex 2
Source files should not have any duplicated blocks 2
Return of boolean expressions should not be wrapped into an "if-then-else" statement 1
Utility classes should not have public constructors 1
Collapsible "if" statements should be merged 1
Nested code blocks should not be used 1
Loggers should be "private static final" and should share a naming convention 1
Class names should comply with a naming convention 1
Loops should not contain more than a single "break" or "continue" statement 1