src/main/java/org/opentripplanner/routing/util

Severity

Blocker 0
Critical 0
Major 39
Minor 33
Info 1

Rule

Empty arrays and collections should be returned instead of null 6
Class variable fields should not have public accessibility 6
Method parameters, caught exceptions and foreach variables should not be reassigned 5
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 4
Local variable and method parameter names should comply with a naming convention 3
Methods should not be too complex 3
Control structures should use curly braces 2
Methods should not be empty 2
Expressions should not be too complex 1
Utility classes should not have public constructors 1
"FIXME" tags should be handled 1
Unused method parameters should be removed 1
Sections of code should not be "commented out" 1
Loggers should be "private static final" and should share a naming convention 1
Branches should have sufficient coverage by unit tests 1
Loops should not contain more than a single "break" or "continue" statement 1