src/main/java/org/opentripplanner/graph_builder/module/osm

Severity

Blocker 0
Critical 0
Major 328
Minor 466
Info 21

Rule

Control structures should use curly braces 78
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 37
Class variable fields should not have public accessibility 29
Methods should not be too complex 29
Package names should comply with a naming convention 25
Strings literals should be placed on the left side when checking for equality 14
Loops should not contain more than a single "break" or "continue" statement 12
Collection.isEmpty() should be used to test for emptiness 12
Local variable and method parameter names should comply with a naming convention 10
Loggers should be "private static final" and should share a naming convention 7
Sections of code should not be "commented out" 6
Collapsible "if" statements should be merged 5
Expressions should not be too complex 5
Exception handlers should preserve the original exceptions 5
Method parameters, caught exceptions and foreach variables should not be reassigned 5
Branches should have sufficient coverage by unit tests 5
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 4
Useless parentheses around expressions should be removed to prevent any misunderstanding 4
Labels should not be used 4
Field names should comply with a naming convention 4
Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used 3
Empty arrays and collections should be returned instead of null 3
"for" loop stop conditions should be invariant 3
Classes should not be too complex 3
Methods should not have too many parameters 2
Unused method parameters should be removed 2
Utility classes should not have public constructors 2
"public static" fields should be constant 2
Constant names should comply with a naming convention 2
"FIXME" tags should be handled 1
Public constants and fields initialized at declaration should be "static final" rather than merely "final" 1
Local variables should not shadow class fields 1
Generic exceptions should never be thrown 1
Source files should not have any duplicated blocks 1
"switch" statements should end with "default" clauses 1