src/main/java/org/opentripplanner/analyst/batch

Severity

Blocker 0
Critical 6
Major 109
Minor 60
Info 3

Rule

Throwable.printStackTrace(...) should not be called 5
Exit methods should not be called 1
Class variable fields should not have public accessibility 35
Control structures should use curly braces 25
Branches should have sufficient coverage by unit tests 11
Exception handlers should preserve the original exceptions 7
Sections of code should not be "commented out" 6
Local variables should not shadow class fields 4
Unused "private" fields should be removed 3
Methods should not be too complex 3
A close curly brace should be located at the beginning of a line 3
Generic exceptions should never be thrown 3
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 2
Local variable and method parameter names should comply with a naming convention 2
Loggers should be "private static final" and should share a naming convention 1
Try-catch blocks should not be nested 1
Strings literals should be placed on the left side when checking for equality 1
Empty statements should be removed 1
Source files should not have any duplicated blocks 1
Comments should not be located at the end of lines of code 22
Magic numbers should not be used 21
The members of an interface declaration or class should appear in a pre-defined order 11
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 3
Tabulation characters should not be used 1
Local Variables should not be declared and then immediately returned or thrown 1
Useless imports should be removed 1
"TODO" tags should be handled 3