src/main/java/org/opentripplanner/routing/impl

Severity

Blocker 0
Critical 3
Major 152
Minor 94
Info 15

Rule

Throwable.printStackTrace(...) should not be called 2
Switch cases should end with an unconditional "break" statement 1
Control structures should use curly braces 30
Class variable fields should not have public accessibility 16
Statements should be on separate lines 13
Methods should not be too complex 11
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 11
Local variable and method parameter names should comply with a naming convention 11
Branches should have sufficient coverage by unit tests 8
Collection.isEmpty() should be used to test for emptiness 8
"switch case" clauses should not have too many lines 7
Sections of code should not be "commented out" 5
Loops should not contain more than a single "break" or "continue" statement 5
Strings literals should be placed on the left side when checking for equality 4
Exception handlers should preserve the original exceptions 4
Collapsible "if" statements should be merged 3
Empty arrays and collections should be returned instead of null 3
Generic exceptions should never be thrown 2
Unused local variables should be removed 2
Methods should not be empty 1
Loggers should be "private static final" and should share a naming convention 1
Labels should not be used 1
"switch" statements should end with "default" clauses 1
Useless parentheses around expressions should be removed to prevent any misunderstanding 1
Unused method parameters should be removed 1
Unused "private" fields should be removed 1
"FIXME" tags should be handled 1
Try-catch blocks should not be nested 1
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 29
Magic numbers should not be used 24
Comments should not be located at the end of lines of code 17
The members of an interface declaration or class should appear in a pre-defined order 11
Useless imports should be removed 7
Tabulation characters should not be used 5
String literals should not be duplicated 1
"TODO" tags should be handled 15