src/main/java/org/opentripplanner/routing/graph

Severity

Blocker 2
Critical 0
Major 153
Minor 52
Info 15

Rule

Class variable fields should not have public accessibility 38
Control structures should use curly braces 34
Statements should be on separate lines 19
Local variables should not shadow class fields 9
Sections of code should not be "commented out" 9
Public methods should throw at most one checked exception 5
Generic exceptions should never be thrown 4
Methods should not be too complex 4
Collection.isEmpty() should be used to test for emptiness 3
"FIXME" tags should be handled 3
Useless parentheses around expressions should be removed to prevent any misunderstanding 3
Branches should have sufficient coverage by unit tests 3
Unused method parameters should be removed 2
Public constants and fields initialized at declaration should be "static final" rather than merely "final" 2
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 2
Unused "private" fields should be removed 2
Standard outputs should not be used directly to log anything 2
Local variable and method parameter names should comply with a naming convention 2
Loops should not contain more than a single "break" or "continue" statement 2
Strings literals should be placed on the left side when checking for equality 1
Field names should comply with a naming convention 1
Generic wildcard types should not be used in return parameters 1
Unused local variables should be removed 1
"for" loop stop conditions should be invariant 1