src/main/java/org/opentripplanner/routing/edgetype/factory

Severity

Blocker 1
Critical 1
Major 92
Minor 53
Info 15

Rule

"equals(Object obj)" and "hashCode()" should be overridden in pairs 1
Methods named "equals" should override Object.equals(Object) 1
Control structures should use curly braces 20
Class variable fields should not have public accessibility 16
"FIXME" tags should be handled 9
Methods should not be too complex 7
Sections of code should not be "commented out" 6
Field names should comply with a naming convention 5
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 4
Exception classes should be immutable 3
Loops should not contain more than a single "break" or "continue" statement 2
Unused method parameters should be removed 2
Labels should not be used 2
Generic exceptions should never be thrown 2
Statements should be on separate lines 2
Collapsible "if" statements should be merged 2
Useless parentheses around expressions should be removed to prevent any misunderstanding 1
Empty arrays and collections should be returned instead of null 1
Collection.isEmpty() should be used to test for emptiness 1
"switch case" clauses should not have too many lines 1
Strings literals should be placed on the left side when checking for equality 1
Methods should not have too many parameters 1
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 1
Deprecated elements should have both the annotation and the Javadoc tag 1
Classes should not be too complex 1
Branches should have sufficient coverage by unit tests 1
Magic numbers should not be used 32
Comments should not be located at the end of lines of code 10
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 9
Local Variables should not be declared and then immediately returned or thrown 2
"TODO" tags should be handled 14
Deprecated code should be removed eventually 1