src/main/java/org/opentripplanner/routing/edgetype

Severity

Blocker 3
Critical 1
Major 269
Minor 157
Info 48

Rule

"equals(Object obj)" and "hashCode()" should be overridden in pairs 3
Throwable.printStackTrace(...) should not be called 1
Control structures should use curly braces 64
Statements should be on separate lines 36
Class variable fields should not have public accessibility 22
Methods should not be too complex 18
Branches should have sufficient coverage by unit tests 14
"FIXME" tags should be handled 14
Source files should not have any duplicated blocks 10
Sections of code should not be "commented out" 10
Collapsible "if" statements should be merged 9
Local variable and method parameter names should comply with a naming convention 8
Useless parentheses around expressions should be removed to prevent any misunderstanding 7
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 6
Field names should comply with a naming convention 6
"switch case" clauses should not have too many lines 6
Unused local variables should be removed 5
Loops should not contain more than a single "break" or "continue" statement 5
Unused method parameters should be removed 3
A close curly brace should be located at the beginning of a line 3
Standard outputs should not be used directly to log anything 3
Labels should not be used 3
Local variables should not shadow class fields 3
Collection.isEmpty() should be used to test for emptiness 3
Exception handlers should preserve the original exceptions 2
Unused "private" fields should be removed 2
Generic exceptions should never be thrown 2
Loggers should be "private static final" and should share a naming convention 1
Method parameters, caught exceptions and foreach variables should not be reassigned 1
Expressions should not be too complex 1
Methods should not have too many parameters 1
Empty statements should be removed 1
Magic numbers should not be used 72
Comments should not be located at the end of lines of code 46
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 15
Useless imports should be removed 7
Tabulation characters should not be used 6
Local Variables should not be declared and then immediately returned or thrown 4
Modifiers should be declared in the correct order 3
Array designators "[]" should be on the type, not the variable 2
String literals should not be duplicated 1
The members of an interface declaration or class should appear in a pre-defined order 1
"TODO" tags should be handled 48