src/main/java/org/opentripplanner/routing/core

Severity

Blocker 0
Critical 0
Major 399
Minor 155
Info 21

Rule

Class variable fields should not have public accessibility 128
Control structures should use curly braces 108
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 25
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 21
Branches should have sufficient coverage by unit tests 15
Methods should not be too complex 12
Statements should be on separate lines 9
Sections of code should not be "commented out" 8
Strings literals should be placed on the left side when checking for equality 8
Collapsible "if" statements should be merged 8
Useless parentheses around expressions should be removed to prevent any misunderstanding 6
Collection.isEmpty() should be used to test for emptiness 5
Method parameters, caught exceptions and foreach variables should not be reassigned 5
"FIXME" tags should be handled 5
Generic exceptions should never be thrown 5
Constant names should comply with a naming convention 5
Expressions should not be too complex 4
Standard outputs should not be used directly to log anything 3
Deprecated elements should have both the annotation and the Javadoc tag 3
Exception handlers should preserve the original exceptions 3
Unused "private" fields should be removed 2
A close curly brace should be located at the beginning of a line 2
Loops should not contain more than a single "break" or "continue" statement 2
"switch" statements should end with "default" clauses 1
Unused method parameters should be removed 1
Empty arrays and collections should be returned instead of null 1
Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used 1
Local variable and method parameter names should comply with a naming convention 1
Field names should comply with a naming convention 1
Classes should not be too complex 1
Magic numbers should not be used 109
Comments should not be located at the end of lines of code 27
Modifiers should be declared in the correct order 5
Tabulation characters should not be used 4
The members of an interface declaration or class should appear in a pre-defined order 3
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 3
String literals should not be duplicated 1
Array designators "[]" should be on the type, not the variable 1
Local Variables should not be declared and then immediately returned or thrown 1
Useless imports should be removed 1
"TODO" tags should be handled 18
Deprecated code should be removed eventually 3