src/main/java/org/opentripplanner/profile

Severity

Blocker 2
Critical 4
Major 416
Minor 225
Info 32

Rule

super.finalize() should be called at the end of Object.finalize() implementations 1
"equals(Object obj)" and "hashCode()" should be overridden in pairs 1
"equals(Object obj)" should be overridden along with the "compareTo(T obj)" method 3
The Object.finalize() method should not be overriden 1
Class variable fields should not have public accessibility 87
Control structures should use curly braces 78
Statements should be on separate lines 74
Local variable and method parameter names should comply with a naming convention 20
Branches should have sufficient coverage by unit tests 19
"switch case" clauses should not have too many lines 19
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 17
"FIXME" tags should be handled 15
Methods should not be too complex 12
Sections of code should not be "commented out" 11
A close curly brace should be located at the beginning of a line 9
Unused "private" fields should be removed 6
Strings literals should be placed on the left side when checking for equality 6
Labels should not be used 6
Methods should not be empty 6
Unused local variables should be removed 4
Standard outputs should not be used directly to log anything 4
Generic exceptions should never be thrown 3
Local variables should not shadow class fields 3
Source files should not have any duplicated blocks 2
Collection.isEmpty() should be used to test for emptiness 2
Loops should not contain more than a single "break" or "continue" statement 2
Useless parentheses around expressions should be removed to prevent any misunderstanding 2
Public constants and fields initialized at declaration should be "static final" rather than merely "final" 1
Unused method parameters should be removed 1
"Object.finalize()" should remain protected (versus public) when overriding 1
Classes that override "clone" should be "Cloneable" and call "super.clone()" 1
Empty arrays and collections should be returned instead of null 1
Method parameters, caught exceptions and foreach variables should not be reassigned 1
Empty statements should be removed 1
Utility classes should not have public constructors 1
Field names should comply with a naming convention 1
Comments should not be located at the end of lines of code 84
Magic numbers should not be used 73
Useless imports should be removed 22
The members of an interface declaration or class should appear in a pre-defined order 21
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 19
Tabulation characters should not be used 4
Local Variables should not be declared and then immediately returned or thrown 2
"TODO" tags should be handled 32