src/main/java/org/opentripplanner/common/geometry

Severity

Blocker 0
Critical 0
Major 219
Minor 184
Info 11

Rule

Control structures should use curly braces 66
Local variable and method parameter names should comply with a naming convention 47
Method parameters, caught exceptions and foreach variables should not be reassigned 13
Type parameter names should comply with a naming convention 11
Branches should have sufficient coverage by unit tests 10
Methods should not be too complex 8
Class variable fields should not have public accessibility 8
"switch case" clauses should not have too many lines 7
Sections of code should not be "commented out" 7
Empty arrays and collections should be returned instead of null 6
Useless parentheses around expressions should be removed to prevent any misunderstanding 5
Utility classes should not have public constructors 5
Field names should comply with a naming convention 4
"switch" statements should end with "default" clauses 3
Statements should be on separate lines 3
Loops should not contain more than a single "break" or "continue" statement 2
Lambdas and anonymous classes should not have too many lines 2
Unused "private" fields should be removed 2
Generic exceptions should never be thrown 2
Labels should not be used 2
Source files should not have any duplicated blocks 2
"public static" fields should be constant 1
Generic wildcard types should not be used in return parameters 1
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 1
Expressions should not be too complex 1
Magic numbers should not be used 146
Comments should not be located at the end of lines of code 24
Local Variables should not be declared and then immediately returned or thrown 4
Tabulation characters should not be used 3
The members of an interface declaration or class should appear in a pre-defined order 2
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 2
Modifiers should be declared in the correct order 1
Boolean literals should not be redundant 1
Useless imports should be removed 1
"TODO" tags should be handled 11