src/main/java/org/opentripplanner/common

Severity

Blocker 1
Critical 3
Major 114
Minor 62
Info 4

Rule

Jump statements should not occur in "finally" blocks 1
Throwable.printStackTrace(...) should not be called 2
Execution of the Garbage Collector should be triggered only by the JVM 1
Control structures should use curly braces 32
Class variable fields should not have public accessibility 22
Branches should have sufficient coverage by unit tests 8
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 7
Local variable and method parameter names should comply with a naming convention 7
Statements should be on separate lines 7
Exception handlers should preserve the original exceptions 4
Methods should not be too complex 4
Standard outputs should not be used directly to log anything 3
Utility classes should not have public constructors 3
A close curly brace should be located at the beginning of a line 2
Sections of code should not be "commented out" 2
Constant names should comply with a naming convention 2
Field names should comply with a naming convention 2
Loops should not contain more than a single "break" or "continue" statement 2
"switch" statements should end with "default" clauses 1
Loggers should be "private static final" and should share a naming convention 1
"FIXME" tags should be handled 1
Strings literals should be placed on the left side when checking for equality 1
Unused "private" fields should be removed 1
Generic exceptions should never be thrown 1
Method names should comply with a naming convention 1
Magic numbers should not be used 28
The members of an interface declaration or class should appear in a pre-defined order 12
String literals should not be duplicated 9
Useless imports should be removed 7
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 3
Comments should not be located at the end of lines of code 2
Tabulation characters should not be used 1
"TODO" tags should be handled 4