src/main/java/org/opentripplanner/api/common

Severity

Blocker 0
Critical 1
Major 38
Minor 37
Info 2

Rule

Throwable.printStackTrace(...) should not be called 1
Control structures should use curly braces 4
Local variables should not shadow class fields 4
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 3
Exception handlers should preserve the original exceptions 3
Method parameters, caught exceptions and foreach variables should not be reassigned 2
Nested code blocks should not be used 2
Collection.isEmpty() should be used to test for emptiness 2
Methods should not be too complex 2
Field names should comply with a naming convention 2
Branches should have sufficient coverage by unit tests 2
Exception classes should be immutable 1
"FIXME" tags should be handled 1
Strings literals should be placed on the left side when checking for equality 1
Unused "private" fields should be removed 1
Collapsible "if" statements should be merged 1
Statements should be on separate lines 1
Local variable and method parameter names should comply with a naming convention 1
Generic exceptions should never be thrown 1
Nested blocks of code should not be left empty 1
Close curly brace and the next "else", "catch" and "finally" keywords should be located on the same line 1
An open curly brace should be located at the end of a line 1
Class variable fields should not have public accessibility 1
Magic numbers should not be used 32
Comments should not be located at the end of lines of code 2
Tabulation characters should not be used 1
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 1
Useless imports should be removed 1
"TODO" tags should be handled 2