src/main/java/org/opentripplanner/graph_builder/module/ned

Severity

Blocker 0
Critical 0
Major 123
Minor 66
Info 1

Rule

Generic exceptions should never be thrown 30
Control structures should use curly braces 10
Methods should not be too complex 9
Branches should have sufficient coverage by unit tests 7
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" 7
Package names should comply with a naming convention 7
Strings literals should be placed on the left side when checking for equality 7
Loops should not contain more than a single "break" or "continue" statement 5
Class variable fields should not have public accessibility 5
Local variable and method parameter names should comply with a naming convention 5
Exception handlers should preserve the original exceptions 4
Loggers should be "private static final" and should share a naming convention 4
Collapsible "if" statements should be merged 4
Method parameters, caught exceptions and foreach variables should not be reassigned 3
Labels should not be used 3
Field names should comply with a naming convention 2
Useless parentheses around expressions should be removed to prevent any misunderstanding 2
Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used 1
Collection.isEmpty() should be used to test for emptiness 1
Try-catch blocks should not be nested 1
Empty arrays and collections should be returned instead of null 1
"FIXME" tags should be handled 1
Statements should be on separate lines 1
A close curly brace should be located at the beginning of a line 1
Empty statements should be removed 1
Sections of code should not be "commented out" 1
Magic numbers should not be used 30
Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply 16
Comments should not be located at the end of lines of code 12
Local Variables should not be declared and then immediately returned or thrown 4
Array designators "[]" should be on the type, not the variable 2
String literals should not be duplicated 1
The members of an interface declaration or class should appear in a pre-defined order 1
"TODO" tags should be handled 1